-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some migrations not applied / not defined #143
Comments
Not all of these are doable with rector, but I can update the 40 rules for the ones we can automatically update. |
@markstory I've checked them briefle and all can be automated. |
Thanks for letting us know about that @TomasVotruba I'll circle back on this and figure out how to do the other changes. |
We should probably close and open with a checklist of items not yet processed, so we can tick them off once done. |
Table->newEntity()
should be migrated toTable->newEmptyEntity()
, validating thatnewEntity()
did not originally contain any arguments / data for entity creation$this->Paginator->counter(['format' => __('format text')])
should be migrated to$this->Paginator->counter(__('format text'))
public function buildValidator(Event $event, Validator $validator, $name)
should be migrated topublic function validationDefault(Validator $validator): Validator
if the methodvalidationDefault
is not yet definedpublic function validate(array $data)
should be migrated topublic function validate(array $data): bool
protected function _buildSchema(Schema $schema)
should be migrated toprotected function _buildSchema(Schema $schema): Schema
public function getData($field = null)
should get migrated topublic function getData(?string $field = null)
should be migrated to
thus specifically providing order, if it was not provided before
The text was updated successfully, but these errors were encountered: