Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Make a common base image #1390

Open
2 tasks
zhujian7 opened this issue Feb 20, 2020 · 3 comments
Open
2 tasks

Proposal: Make a common base image #1390

zhujian7 opened this issue Feb 20, 2020 · 3 comments
Labels
kind/proposal Proposing Changes to Cyclone

Comments

@zhujian7
Copy link
Collaborator

zhujian7 commented Feb 20, 2020

Proposal: Make a common base image

Background

There are many component images in Cyclone, cyclone-server, cyclone-workflow-controller, cyclone-workflow-coordinator, etc. They use a different base image, such as alpine:3.8 ubuntu:18.10 and bash:4.1.17, and almost every image built needs to connect to the network, installing subversion, installing docker and so on.

Disadvantages of that:

  • we can not build even one Cyclone image in a no network environment
  • we must do some duplicated works, like downloading subversion, in some images building.

Proposal

I think we can:

  • Unify all base image form alpine:3.8 ubuntu:18.10 and bash:4.1.17 to alpine:3.8.(almostly done except for sonarqube)
  • Then creates a common base image based on alpine:3.8 and installed all tools from the internet for other component images. Naming the common base image is difficult for me, how about cyclone-base?

Advantages

Could resolve problems described in the background

Disavantages

Some images may container some tools they don't need and make their size bigger than before. But I think that is acceptable.

/cc @supereagle @hyy0322 @bbbmj

Uncomment only one, leave it on its own line:

/kind proposal

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@zhujian7 zhujian7 added the kind/proposal Proposing Changes to Cyclone label Feb 20, 2020
@zhujian7
Copy link
Collaborator Author

zhujian7 commented Apr 8, 2020

@supereagle @hyy0322 WDYT?

@hyy0322
Copy link
Contributor

hyy0322 commented Apr 8, 2020

LGTM, Using a common base image will make it easier to maintain. Although it may cause cyclone base image size larger.

@supereagle
Copy link
Member

Generally SGTM

  • Naming the common base image is difficult for me, how about cyclone-base?

You can refer to other popular projects for best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Proposing Changes to Cyclone
Projects
None yet
Development

No branches or pull requests

3 participants