-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The WaveshareDisplay associated color is not properly documented #122
Comments
Sounds like a good idea 👍 |
I se no other reason than rendering speed to provide a specific trait fir 3 color versions, so I wrote this.
It implies that most (b) versions, ie tricolor, of existing display will work differently than they do currently, but they will be closer to what bw versions and octocolor versions provide. And it also means the definition will match their |
Any news on this ? |
Some small changes but the meaning hopefully should have stayed the same. This also sounds like a good change to make the usage and development of this crate more intuitive. |
Since it is an associated type, most driver implement it as the color type the epd supports.
However since there is a separate WaveshareThreeColorDisplay trait, some driver implement it only as a black and white color and let the 3 colors handling to WaveshareThreeColorDisplay (eg epd1in54c).
We should document and enforce the right behaviour to make sure this is coherent between various implementations.
The text was updated successfully, but these errors were encountered: