Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tf from cadmium::tfidf #2

Open
rmarronnier opened this issue Aug 29, 2019 · 1 comment
Open

Use tf from cadmium::tfidf #2

rmarronnier opened this issue Aug 29, 2019 · 1 comment
Assignees
@rmarronnier
Labels
enhancement New feature or request

Comments

@rmarronnier
Copy link
Member

Right now the term frequencies are calculated custom methods in AbstractSummarizer.

To respect the "Eat your dog food" saying, replace them using cadmium::tfidf native module.
@rmarronnier rmarronnier added the enhancement New feature or request label Aug 29, 2019
@rmarronnier rmarronnier self-assigned this Aug 29, 2019
@watzon
Copy link
Member

watzon commented Aug 29, 2019

Great plan, I want things to be as integrated as possible so anywhere you see something like this occurring let's make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmarronnier rmarronnier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@watzon @rmarronnier