Skip to content

Commit de0653f

Browse files
committed
add metric tags for activity task disaptch (#4821)
1 parent 3581be5 commit de0653f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

service/history/execution/mutable_state_builder.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2170,7 +2170,11 @@ func (e *mutableStateBuilder) tryDispatchActivityTask(
21702170
ai *persistence.ActivityInfo,
21712171
ctx context.Context,
21722172
) bool {
2173-
e.metricsClient.Scope(metrics.HistoryScheduleDecisionTaskScope).IncCounter(metrics.DecisionTypeScheduleActivityDispatchCounter)
2173+
taggedScope := e.metricsClient.Scope(metrics.HistoryScheduleDecisionTaskScope).Tagged(
2174+
metrics.DomainTag(e.domainEntry.GetInfo().Name),
2175+
metrics.WorkflowTypeTag(e.GetWorkflowType().Name),
2176+
metrics.TaskListTag(ai.TaskList))
2177+
taggedScope.IncCounter(metrics.DecisionTypeScheduleActivityDispatchCounter)
21742178
err := e.shard.GetService().GetMatchingClient().AddActivityTask(ctx, &types.AddActivityTaskRequest{
21752179
DomainUUID: e.executionInfo.DomainID,
21762180
SourceDomainUUID: e.domainEntry.GetInfo().ID,
@@ -2189,9 +2193,8 @@ func (e *mutableStateBuilder) tryDispatchActivityTask(
21892193
ScheduledTimestampOfThisAttempt: common.Int64Ptr(ai.ScheduledTime.UnixNano()),
21902194
},
21912195
})
2192-
21932196
if err == nil {
2194-
e.metricsClient.Scope(metrics.HistoryScheduleDecisionTaskScope).IncCounter(metrics.DecisionTypeScheduleActivityDispatchSucceedCounter)
2197+
taggedScope.IncCounter(metrics.DecisionTypeScheduleActivityDispatchSucceedCounter)
21952198
return true
21962199
}
21972200
return false

0 commit comments

Comments
 (0)