apparently I had not committed before doing that experiment, oops

Groxx · Groxx · commit 8ed692444c83 · 2025-09-24T16:23:03.000-05:00
diff --git a/common/metrics/histograms_test.go b/common/metrics/histograms_test.go
@@ -6,7 +6,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"go.uber.org/yarpc"
 )
 
 func TestHistogramValues(t *testing.T) {
@@ -166,7 +165,6 @@ func checkHistogram[T any](t *testing.T, h histogrammy[T], expected string) {
 		t.Log(str)
 		buf.WriteString(str)
 	})
-	yarpc.CallFromContext(ctx).Transport()
 	if strings.TrimSpace(expected) != strings.TrimSpace(buf.String()) {
 		t.Error("histogram definition changed, update the test if this is intended")
 	}

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ import (`
`6`	`6`	`"testing"`
`7`	`7`
`8`	`8`	`"github.com/stretchr/testify/assert"`
`9`		`- "go.uber.org/yarpc"`
`10`	`9`	`)`
`11`	`10`
`12`	`11`	`func TestHistogramValues(t *testing.T) {`
`@@ -166,7 +165,6 @@ func checkHistogram[T any](t *testing.T, h histogrammy[T], expected string) {`
`166`	`165`	`t.Log(str)`
`167`	`166`	`buf.WriteString(str)`
`168`	`167`	`})`
`169`		`- yarpc.CallFromContext(ctx).Transport()`
`170`	`168`	`if strings.TrimSpace(expected) != strings.TrimSpace(buf.String()) {`
`171`	`169`	`t.Error("histogram definition changed, update the test if this is intended")`
`172`	`170`	`}`