Added todo

jakobht · jakobht · commit 298f92f22efe · 2025-10-02T13:21:58.000+02:00
Signed-off-by: Jakob Haahr Taankvist &lt;jht@uber.com&gt;
diff --git a/service/sharddistributor/store/etcd/executorstore/etcdstore.go b/service/sharddistributor/store/etcd/executorstore/etcdstore.go
@@ -248,6 +248,7 @@ func (s *executorStoreImpl) GetState(ctx context.Context, namespace string) (*st
 	}, nil
 }
 
+// TODO this is too naive we need to be more specific about what changes different components need to react to
 func (s *executorStoreImpl) Subscribe(ctx context.Context, namespace string) (<-chan int64, error) {
 	revisionChan := make(chan int64, 1)
 	watchPrefix := etcdkeys.BuildExecutorPrefix(s.prefix, namespace)

Original file line number	Diff line number	Diff line change
`@@ -248,6 +248,7 @@ func (s executorStoreImpl) GetState(ctx context.Context, namespace string) (st`
`248`	`248`	`}, nil`
`249`	`249`	`}`
`250`	`250`
	`251`	`+// TODO this is too naive we need to be more specific about what changes different components need to react to`
`251`	`252`	`func (s *executorStoreImpl) Subscribe(ctx context.Context, namespace string) (<-chan int64, error) {`
`252`	`253`	`revisionChan := make(chan int64, 1)`
`253`	`254`	`watchPrefix := etcdkeys.BuildExecutorPrefix(s.prefix, namespace)`