fix unit test

Signed-off-by: Shijie Sheng <[email protected]>

Author: shijiesheng

tests/cadence/_internal/workflow/test_workflow_engine_integration.py

@@ -31,20 +31,22 @@ def mock_client(self):
         return client
 
     @pytest.fixture
-    def workflow_info(self):
+    def workflow_info(self, mock_client, decision_task):
         """Create workflow info."""
-        data_converter = Mock()
-        data_converter.from_data = Mock(return_value=["test-input"])
         return WorkflowInfo(
             workflow_type="test_workflow",
             workflow_domain="test-domain",
             workflow_id="test-workflow-id",
             workflow_run_id="test-run-id",
             workflow_task_list="test-task-list",
-            workflow_events = [],
-            data_converter=data_converter,
+            workflow_events=decision_task.history.events,
+            data_converter=mock_client.data_converter,
         )
 
+    @pytest.fixture
+    def decision_task(self):
+        return self.create_mock_decision_task()
+
     @pytest.fixture
     def mock_workflow_definition(self):
         """Create a mock workflow definition."""
@@ -105,9 +107,10 @@ def create_mock_decision_task(
         return decision_task
 
     @pytest.mark.asyncio
-    async def test_process_decision_success(self, workflow_engine, mock_client):
+    async def test_process_decision_success(
+        self, workflow_engine, mock_client, decision_task
+    ):
         """Test successful decision processing."""
-        decision_task = self.create_mock_decision_task()
 
         # Mock the decision manager to return some decisions
         with patch.object(
@@ -123,9 +126,10 @@ async def test_process_decision_success(self, workflow_engine, mock_client):
             assert len(result.decisions) == 1
 
     @pytest.mark.asyncio
-    async def test_process_decision_with_history(self, workflow_engine, mock_client):
+    async def test_process_decision_with_history(
+        self, workflow_engine, mock_client, decision_task
+    ):
         """Test decision processing with history events."""
-        decision_task = self.create_mock_decision_task()
 
         # Mock the decision manager
         with patch.object(
@@ -144,14 +148,12 @@ async def test_process_decision_with_history(self, workflow_engine, mock_client)
 
     @pytest.mark.asyncio
     async def test_process_decision_workflow_complete(
-        self, workflow_engine, mock_client
+        self, workflow_engine, mock_client, decision_task
     ):
         """Test decision processing when workflow is already complete."""
         # Mark workflow as complete
         workflow_engine._is_workflow_complete = True
 
-        decision_task = self.create_mock_decision_task()
-
         with patch.object(
             workflow_engine._decision_manager,
             "collect_pending_decisions",
@@ -165,9 +167,10 @@ async def test_process_decision_workflow_complete(
             assert len(result.decisions) == 0
 
     @pytest.mark.asyncio
-    async def test_process_decision_error_handling(self, workflow_engine, mock_client):
+    async def test_process_decision_error_handling(
+        self, workflow_engine, mock_client, decision_task
+    ):
         """Test decision processing error handling."""
-        decision_task = self.create_mock_decision_task()
 
         # Mock the decision manager to raise an exception
         with patch.object(
@@ -183,9 +186,10 @@ async def test_process_decision_error_handling(self, workflow_engine, mock_clien
             assert len(result.decisions) == 0
 
     @pytest.mark.asyncio
-    async def test_extract_workflow_input_success(self, workflow_engine, mock_client):
+    async def test_extract_workflow_input_success(
+        self, workflow_engine: "WorkflowEngine", mock_client, decision_task
+    ):
         """Test successful workflow input extraction."""
-        decision_task = self.create_mock_decision_task()
 
         # Extract workflow input
         input_data = workflow_engine._extract_workflow_input(decision_task)
@@ -241,10 +245,9 @@ async def test_extract_workflow_input_no_started_event(
 
     @pytest.mark.asyncio
     async def test_extract_workflow_input_deserialization_error(
-        self, workflow_engine, mock_client
+        self, workflow_engine, mock_client, decision_task
     ):
         """Test workflow input extraction with deserialization error."""
-        decision_task = self.create_mock_decision_task()
 
         # Mock data converter to raise an exception
         mock_client.data_converter.from_data = AsyncMock(
@@ -313,15 +316,14 @@ def test_workflow_engine_initialization(
 
     @pytest.mark.asyncio
     async def test_workflow_engine_without_workflow_definition(
-        self, mock_client, workflow_info
+        self, mock_client: Client, workflow_info, decision_task
     ):
         """Test WorkflowEngine without workflow definition."""
         engine = WorkflowEngine(
-            info=workflow_info, client=mock_client, workflow_definition=None
+            info=workflow_info,
+            workflow_definition=None,
         )
 
-        decision_task = self.create_mock_decision_task()
-
         with patch.object(
             engine._decision_manager, "collect_pending_decisions", return_value=[]
         ):
@@ -334,10 +336,9 @@ async def test_workflow_engine_without_workflow_definition(
 
     @pytest.mark.asyncio
     async def test_workflow_engine_workflow_completion(
-        self, workflow_engine, mock_client
+        self, workflow_engine, mock_client, decision_task
     ):
         """Test workflow completion detection."""
-        decision_task = self.create_mock_decision_task()
 
         # Create a workflow definition that returns a result (indicating completion)
         class CompletingWorkflow:
@@ -372,10 +373,9 @@ def test_close_event_loop(self, workflow_engine):
 
     @pytest.mark.asyncio
     async def test_process_decision_with_query_results(
-        self, workflow_engine, mock_client
+        self, workflow_engine, mock_client, decision_task
     ):
         """Test decision processing with query results."""
-        decision_task = self.create_mock_decision_task()
 
         # Mock the decision manager to return decisions with query results
         mock_decisions = [Mock()]