Skip to content

Commit 6b9605b

Browse files
authored
Fix mapping for cancel cause for proto requests (#1454)
Pretty simple / clear missing field. No real reason to suspect other fields are similar, so I think this is all that's necessary, but it'd be really nice to have a "must fill all struct fields" linter :|
1 parent ee9065f commit 6b9605b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

internal/compatibility/proto/request.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ func RequestCancelWorkflowExecutionRequest(t *shared.RequestCancelWorkflowExecut
242242
Domain: t.GetDomain(),
243243
WorkflowExecution: WorkflowExecution(t.WorkflowExecution),
244244
Identity: t.GetIdentity(),
245+
Cause: t.GetCause(),
245246
RequestId: t.GetRequestId(),
246247
}
247248
}
@@ -553,7 +554,7 @@ func UpdateDomainRequest(t *shared.UpdateDomainRequest) *apiv1.UpdateDomainReque
553554
request.WorkflowExecutionRetentionPeriod = daysToDuration(configuration.WorkflowExecutionRetentionPeriodInDays)
554555
fields = append(fields, DomainUpdateRetentionPeriodField)
555556
}
556-
//if t.EmitMetric != nil {} - DEPRECATED
557+
// if t.EmitMetric != nil {} - DEPRECATED
557558
if configuration.BadBinaries != nil {
558559
request.BadBinaries = BadBinaries(configuration.BadBinaries)
559560
fields = append(fields, DomainUpdateBadBinariesField)

0 commit comments

Comments
 (0)