Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable warning message on ballot measure committees that we have on contributor pages #428

Closed
sfdoran opened this issue Oct 15, 2020 · 2 comments
Assignees
Labels
For2022-11 For the Nov. 8, 2022 election

Comments

@sfdoran
Copy link
Contributor

sfdoran commented Oct 15, 2020

If we add text to the "data warning" column in our committee spreadsheet this appears on the contributor page:

image

We want it to appear on non-candidate committee pages with data warning text, too:

image

@sfdoran sfdoran added the type/bug Something isn't working label Oct 15, 2020
@ckingbailey
Copy link
Contributor

I've started looking into this and I see that you added the data_warning to the committee's row on the spreadsheet, @sfdoran, but I'm not seeing any value at the data_warning key on the markdown file that is generated for Oakland Education Association Political Action Committee, 1345259. I do see that key has the expected value on the Moore for At-Large committee markdown file, 1388168. @tdooner @mikeubell I'm wondering if this is a backend issue. Is it only putting a value for the data_warning key if it's a candidate's committee?

The committee template file, committee.html, looks for the data_warning key regardless of what kind of committee it is:
(from line 20 of committee.html)

    {% if committee.data_warning %}
      <div class="grid grid--full grid--narrow grid--left">
        <div class="grid-col-12">
          {% include alert-message.html message=committee.data_warning %}
        </div>
      </div>
    {% endif %}

I'm able to display a fake data_warning locally by manually adding one to 1345259.md, so it seems like to should work if the key were populated when it gets to the frontend
Screen Shot 2020-10-17 at 10 58 19 PM

@elinaru elinaru changed the title Show data warning on contributor pages for non-candidate or ballot measure committees Show warning on contributor pages for non-candidate or ballot measure committees Sep 4, 2022
@elinaru elinaru changed the title Show warning on contributor pages for non-candidate or ballot measure committees Enable warning message on ballot measure committees that we have on contributor pages Sep 4, 2022
@sfdoran sfdoran added the For2022-11 For the Nov. 8, 2022 election label Sep 4, 2022
@elinaru elinaru removed the type/bug Something isn't working label Sep 4, 2022
@mikeubell
Copy link
Contributor

@sfdoran @ckingbailey As far as I can tell this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For2022-11 For the Nov. 8, 2022 election
Projects
None yet
Development

No branches or pull requests

5 participants