Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine search page design #407

Closed
7 tasks done
anlawyer opened this issue Sep 2, 2020 · 1 comment · Fixed by #414
Closed
7 tasks done

Refine search page design #407

anlawyer opened this issue Sep 2, 2020 · 1 comment · Fixed by #414
Assignees
@anlawyer
Labels
feature/search skill/html-css skill/react

Comments

@anlawyer
Copy link
Member

anlawyer commented Sep 2, 2020 •
edited
Loading

  • Increase size/font of "Clear all" button
  • Increase font size of refinements list (left side filters)
  • Rename refinements list header to say "Filter by election" instead of "Election title".
  • Remove "Oakland" and "General / Special Election" text from the Refinements list items -> Maybe map over the election_date data value instead of the election_title
  • Add space between magnifying search symbol 🔍 and text in the search box
  • Increase the font size inside the search box too
  • Improve text when there's no search entered, "No query" isn't the most user-friendly. "No search entered" or something like that? Do we need any text here? Also note issue Hide pagination when there are no results shown #405 for hiding pagination when there is no search entered yet

Screen Shot 2020-09-01 at 7 49 20 PM

Screen Shot 2020-09-01 at 8 03 26 PM
@anlawyer
Copy link
Member Author

anlawyer commented Sep 2, 2020

Thoughts on a sticky footer for this page (and the app overall)?
Screen Shot 2020-09-01 at 9 07 53 PM

@anlawyer anlawyer self-assigned this Sep 9, 2020
anlawyer added a commit that referenced this issue Sep 9, 2020
@anlawyer
Clean up search page styles
a09d0c7 
Closes #405 and closes #407
Improvements include:
- Increase font size of 'clear all filters' button
- Increase font size of items in refinements list
- Update text to say 'Filter by election', and map over election date instead of election title
- Add space between magnifying glass and input text in search box
- Increase search box font size
- Remove 'No query' text and hide pagination before any search is entered (open to adding back some placeholder text when no search has been entered)
@anlawyer anlawyer mentioned this issue Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anlawyer anlawyer

Labels
feature/search skill/html-css skill/react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up search page styles caciviclab/odca-jekyll
1 participant
@anlawyer