Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current_election value in _localities #370

Closed
anlawyer opened this issue May 11, 2020 · 0 comments · Fixed by #371
Closed

Update current_election value in _localities #370

anlawyer opened this issue May 11, 2020 · 0 comments · Fixed by #371
Assignees

Comments

@anlawyer
Copy link
Member

anlawyer commented May 11, 2020

The current_election value in https://github.com/caciviclab/odca-jekyll/blob/master/_localities/oakland.md is currently set to June 2018, we should update this value to be the next upcoming election.

Caveat: I noticed that the current_election variable isn't actually being used anywhere in the site (which is probably why we hadn't noticed the wrong date before). I think we should take the time to go through the codebase and find these instances of dead code and remove them. There's no point to having them, and it causes additional confusion to the already somewhat-opaque system on which Jekyll operates.

This could also lead to a discussion about the places that we're maintaining some of the data on the frontend rather than ensuring the backend handles all the variable data.

@anlawyer anlawyer changed the title Update Update current_election value in _localities May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants