Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting redis shards name #74

Closed
rmarronnier opened this issue Jul 8, 2023 · 6 comments · Fixed by #90
Closed

Conflicting redis shards name #74

rmarronnier opened this issue Jul 8, 2023 · 6 comments · Fixed by #90

Comments

@rmarronnier
Copy link
Contributor

rmarronnier commented Jul 8, 2023

I followed the installation instructions to add cable to a lucky project and got hit by a shards install issue : crystal-lang/shards#590

Error shard name (redis) has ambiguous sources: 'git: https://github.com/jgaskins/redis.git' and 'git: https://github.com/stefanwille/crystal-redis.git'.

The readme installation part could be updated to :

  cable:
    github: cable-cr/cable
    branch: master
  redis:
    github: jgaskins/redis
    branch: master # lock down if needed

Or a new release could be put out.

@jwoertink
Copy link
Collaborator

Thanks for the reminder. I've been meaning to cut a new release. I've been testing some updates in production to make sure they're solid before doing the release. I think I can try to get that out this weekend.

@rmarronnier
Copy link
Contributor Author

Thanks for looking into it.

@jwoertink
Copy link
Collaborator

I've updated the README for now, but since Crystal 1.9 is coming out this week, I'm going to hold off. I want to make sure things are good on it, and see if there's an Ameba update so we can get specs green.

@rmarronnier
Copy link
Contributor Author

rmarronnier commented Sep 20, 2023

I'm bumping once again into the conflicting redis shard issue : I'm trying to integrate into my app a background job processor (https://github.com/mosquito-cr/mosquito) and that triggers the ambiguous error because it uses the https://github.com/stefanwille/crystal-redis shard. It's the same issue when using https://github.com/hugopl/sidekiq.cr

I could fork and monkey patch the shards for a short term solution but there must be a cleaner / saner way.

What do you think ?

Sorry for the noise. The mosquito shard is using a different jgaskings redis number version.

There is still a conflicting redis shard version when using the sidekiq shard and the jgaskings redis shard. I'll open a issue in their respective repository.

@jwoertink
Copy link
Collaborator

Sorry, I keep forgetting to do this. I will do a release right now. I see Mosquito is set to 0.6.1, but the latest is 0.7.0... Maybe we can just set this one to ~> 0.6 which would allow for both 🤔

@jwoertink
Copy link
Collaborator

Ok, I have a new version ready to go up #80 This won't fix the shard naming issues, but it should fix the issue of versions when using Mosquito.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants