New messages don't trigger new-message event
#78
Comments
|
thanks for the issue, tim! I'll have to dive back into this again at some point it seems :) the commit linked was basically trying to figure out an issue in cabal-desktop, where messages would get duplicated now and then or sth like that |
|
@timgoeller where are you seeing the issues btw, in one of your cabal-bot repos? |
|
Yeah, exactly, I've tried to upgrade the bridge/cabal-bot-core to the latest client version. I'll try to do some more testing in the next days. |
|
lmk how i can help @timgoeller! it'd be a great way for me to ease into dev again tbh :~ |
cblgh
added a commit
that referenced
this issue
Oct 23, 2021
This reverts commit 1dbd522. It seems this commit introduced a regression in functionality such that messages do not appear in channels (#78) and might also be responsible for a similar bug in [email protected] It would be good to only add the relevant message listeners, instead of duplicates, but I think it will have to be done anew with fresh eyes.
|
@timgoeller reverted the commit you identified (as seen above), thanks for filing an issue so it wasn't forgotten! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Haven't had the time yet to really check why this happens, but it seems to be caused by this commit: 1dbd522 (everything works when I revert these changes locally)
If I join a cabal I will receive all historical messages, but not any of the new messages (or at least the event won't be triggered for new messages). This happens even when I join these channels after I've joined the cabal.
The text was updated successfully, but these errors were encountered: