Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement suggestions #23

Open
2 tasks
javruben opened this issue Dec 29, 2014 · 1 comment
Open
2 tasks

Small improvement suggestions #23

javruben opened this issue Dec 29, 2014 · 1 comment

Comments

@javruben
Copy link

  • force ncurses to use the dynamic version of libutl by taking out the -static flag and letting it pick which one to use itself. I linked the systems libutil.so into ncurses-5.9/lib.
  • The script should be able to test to see if python 2.7 is on a system with the name python2, or python2.7.
@javruben
Copy link
Author

More improvement suggestions:

I tried a reinstallation of c9 with tmux installed, and installation still fails. This is the relevant check (line 277):

elif has "tmux" && check_tmux_version tmux; then
echo ':A good version of tmux was found, creating a symlink'

(has "tmux") works, but (check_tmux_version fails) returns false. Two failures cause this:

  • One is on line 262:

if [ $(python -c "ok = 1 if 1.7<=$tmux_version else 0; print ok") -eq 1 ]; then

as:

$ python -c "ok = 1 if 1.7<=1.7 else 0; print ok"
File "", line 1
ok = 1 if 1.7<=1.7 else 0; print ok
^
SyntaxError: invalid syntax

because python is python3.

  • The other error is on line 254:

if [ ! -x $1 ]; then

This line would work, except line 277 calls

"check_tmux_version tmux"

where "tmux" is not an executable; /usr/bin/tmux is. The correct call is, I guess, "check_tmux_version $(which tmux)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant