Skip to content

[Feature request] Import untranspiled components #25

@siddharthkp

Description

@siddharthkp

Importing the source file does not work right now, I simple get a syntax error because of import statements and jsx

This also open another feature request which is to resolve component dependencies in the case of composite components. (the import/require statement depicts the relative path)

Activity

jxnblk

jxnblk commented on Dec 17, 2017

@jxnblk
Member

Would you mind clarifying what source file you are importing? Is this a Lab component that's been exported and used in another React app, or is this a component that you're importing into Lab? If it's the latter, Lab should handle ES imports and JSX, so this might be a bug...

siddharthkp

siddharthkp commented on Dec 17, 2017

@siddharthkp
Author

The latter, tried to import this component:

import React from 'react'

export default () => <div>hi</div>

Bonus: Would be cool if you can also import tokens from theme. I imagine this will work:

import { colors } from './theme.json'
jxnblk

jxnblk commented on Dec 20, 2017

@jxnblk
Member

This is definitely a bug, Lab should be able to import that syntax. Is the imported file in the same folder or a subdirectory of where the lab.json file is located? Also if you can include a snippet from the lab.json file where this import is located that could be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @siddharthkp@jxnblk

        Issue actions

          [Feature request] Import untranspiled components · Issue #25 · c8r/lab