Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC detection sometimes goes wrong #1167

Open
lerno opened this issue Mar 5, 2024 · 5 comments
Open

MSVC detection sometimes goes wrong #1167

lerno opened this issue Mar 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request fixed needs check Fixed, but needs verification that it works

Comments

@lerno
Copy link
Collaborator

lerno commented Mar 5, 2024

-- INFO: Detected executable path at C:/Users/mlb/Documents/DEV/DEPS/c3/
-- INFO: Linker arguments:  /OUT:../build/hello_world.exe /SUBSYSTEM:CONSOLE /DEBUG:FULL /LIBPATH:C:\Program Files (x86)\Windows Kits\10\Lib\10.0.22621.0\um\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\Lib\10.0.22621.0\ucrt\x64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\lib\x64 /NOLOGO build/tmp/hello_world.obj build/tmp/std.ascii.obj build/tmp/std.atomic.obj build/tmp/std.core.mem.allocator.obj build/tmp/std.core.builtin.obj build/tmp/std.core.string.conv.obj build/tmp/std.core.dstring.obj build/tmp/std.core.mem.obj build/tmp/std.core.string.obj build/tmp/std.core.types.obj build/tmp/std.io.obj build/tmp/std.io.file.obj build/tmp/std.io.os.obj build/tmp/libc.obj build/tmp/std.math.obj build/tmp/std.os.backtrace.obj build/tmp/std.os.win32.obj build/tmp/std.collections.list.std.os.backtrace.Backtrace.obj dbghelp.lib kernel32.lib ntdll.lib user32.lib shell32.lib Shlwapi.lib Ws2_32.lib legacy_stdio_definitions.lib ucrtd.lib vcruntimed.lib msvcrtd.lib msvcprtd.lib to 1
lld-link: error: cannot open output file ../build/hello_world.exe: no such file or directory
Failed to create an executable: (null)

In this case VS 2022 was installed.

@lerno
Copy link
Collaborator Author

lerno commented Mar 5, 2024

@C34A I think you added this?

@C34A
Copy link
Contributor

C34A commented Mar 5, 2024

Hi Christoffer,

I believe I did work on this. Unfortunately that was over two years ago, and I have since started university and changed fields. While I do feel some responsibility to maintain this code, I simply don't have time anymore, especially given the fact that the codebase has changed in that time and that I no longer have access to convenient windows development environment to work on this.
I'm sorry I can't offer more help, but as I recall the necessary processes to detect MSVC and associated binaries is somewhat liable to change between visual studio versions. I haven't used VS2022, but it is possible that it simply moved things and the code in utils/find_msvc.c needs updating. This may be documented, or it may be necessary to simply compare the VS versions and see what changed.

@lerno
Copy link
Collaborator Author

lerno commented Mar 5, 2024

It's fine, I pinged just in case you had some idea.

@lerno
Copy link
Collaborator Author

lerno commented Mar 18, 2024

This might be due to having installs in the registry?

@lerno lerno added this to the First release (v1.0) milestone Apr 1, 2024
@lerno lerno self-assigned this May 29, 2024
@lerno
Copy link
Collaborator Author

lerno commented Jun 10, 2024

I've updated the msvc detection now. Testers are very welcome.

@lerno lerno added enhancement New feature or request fixed needs check Fixed, but needs verification that it works labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed needs check Fixed, but needs verification that it works
Projects
None yet
Development

No branches or pull requests

2 participants