Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yinote window doesnt close in Chrome #106

Open
gandalf34 opened this issue Nov 24, 2021 · 21 comments
Open

Yinote window doesnt close in Chrome #106

gandalf34 opened this issue Nov 24, 2021 · 21 comments

Comments

@gandalf34
Copy link

Describe the bug

The yinote window open on the right hand side close in firefox but doesnt close in Chrome.

To Reproduce
Steps to reproduce the behavior:

  1. Click on extension . Yinote will open
  2. Click on the arrow > at he right hand side of the Search field.
  3. Nothing happens.

Expected behavior
It is expected to close by sliding to the right

Screenshots
If applicable, add screenshots to help explain your problem.

Browser (please complete the following information):
-Version 96.0.4664.45 (Official Build) (64-bit)

Additional context
Add any other context about the problem here

yinote.bug.chrome.mp4

.

@hawkiboy
Copy link

hawkiboy commented Jan 4, 2022

Agree, this makes for a BAD experience. You can hit the refresh button and that gets rid of it.

@Broodlisk
Copy link

I have the same issue

@quentin-mckay
Copy link

Same issue for me. I'm on Chrome Version 99.0.4844.74 (Official Build) (64-bit)

@rcsoul
Copy link

rcsoul commented Mar 30, 2022

The same thing happens to me.

@chris2052
Copy link

Same in Brave-Browser

@phanirithvij
Copy link

phanirithvij commented May 25, 2022

same as #105

@No2515
Copy link

No2515 commented Jul 23, 2022

No fix yet?

@nikevelik
Copy link

I have the same issue

@lemattma
Copy link
Contributor

lemattma commented Aug 3, 2022

@shuowu I've been debugging this issue and it seems to be related to the file packages/extension/src/ui/containers/App/styled.js on the transform property:

export const StyledDrawer = styled.div`
  ...

  transition: transform 0.3s;
  /* it's not updating the value, but props.open does change. Maybe some cache issue? */
  transform: ${props => (props.open ? 'translateX(0)' : 'translateX(100%)')}; 

  ...
`;

I'll keep digging but if you know how to fix it please let me know.

lemattma added a commit to lemattma/yi-note that referenced this issue Aug 4, 2022
Passing `open` to the Styled component doesn't refresh the `transform` CSS property.

Resolves: Issue byteyilabs#106
@lemattma
Copy link
Contributor

lemattma commented Aug 4, 2022

I've created a PR fixing this issue: #113

@hh23485
Copy link

hh23485 commented Sep 5, 2022

@shuowu can you help to review this PR and release a new version

I've created a PR fixing this issue: #113

@No2515
Copy link

No2515 commented Sep 5, 2022 via email

@hh23485
Copy link

hh23485 commented Nov 3, 2022

Any updates here?

@shoneriki
Copy link

There seems to be numerous PR's to this extension to fix this issue, but this problem is still prevalent way into 2023...

@ThDag
Copy link

ThDag commented Jul 28, 2023

july 2023 and its still there , didnt got fixed yet??

@shoneriki
Copy link

july 2023 and its still there , didnt got fixed yet??

no, the issue hasn't been fixed yet

@ThDag
Copy link

ThDag commented Aug 11, 2023

i have found a %1000 better tool to take notes on videos thats faster, easier, cleaner

idk if its rude but there is just no way i can use with the bugs and no maintenance

its NattyNote its very not known i found it in some reddit post

you can find it in chrome web store

instead of creating a webpage to store and the notes you took across web, it caches the youtube link so all the notes are in the same place as the video and there is a list of cached files

it stores way less space on the screen after all you need to see when noting a quick sentence is the the text, better then covering the whole side of the screen

@Medullitus
Copy link

trash

@ThDag
Copy link

ThDag commented Aug 13, 2023

why

letuanhai added a commit to letuanhai/yi-note that referenced this issue Oct 15, 2023
Passing `open` to the Styled component doesn't refresh the `transform` CSS property.

Resolves: Issue byteyilabs#106
@mbalassane
Copy link

We can use an alternative for closing the left pane of yinote by refreshing your web page. Press Crtl+r to refresh it quickly and it will disappear

@shuowu
Copy link
Contributor

shuowu commented Feb 18, 2024

Issue has been fixed in version 1.8.0 in both chrome & edge store (pending store review, it will be available in store soon)!

shuowu pushed a commit that referenced this issue Feb 18, 2024
* fix: Drawer does not close

Passing `open` to the Styled component doesn't refresh the `transform` CSS property.

Resolves: Issue #106

* refactor: Removes metadata from the window title from the export filename

Transforms `(123) My super video - YouTube` into just `My super video`

* fix: Fixes deprecated error when using `fromString` and `isUuid`

Also fixes exporting markdown files with links without the video ID nor the `t=` query param.

* fix: Moves uuid to a separate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests