wasi-http v48 requires authority

[ignatz]

I have some code that proxies requests from an axum server to a wasm component. By upgrading to to v48, I'm now triggering: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-http/src/p2/types.rs#L92

The code is correct in: no authority is set, however previously this wasn't an issue. Is this WAI?

[ignatz]

I noticed this only triggers when my server calls itself, i.e.:

client -> axum -> wasm-component ---(*)----> axum -> wasm-component

The request (*) has an authority set when I pass it to wasmtime_wasi_http::default_send_request to deliver it to localhost:

Request { method: GET, uri: http://127.0.0.1:4005/json, version: HTTP/1.1, headers: {}, body: UnsyncBoxBody }

but when axum receives it there's no more authority. The change in behavior may also stem from a change in wasmtime_wasi_http::default_send_request 🤷‍♀️ . I'd love to provide a repro but I'm starting to get whiplash

[ignatz]

wasmtime/crates/wasi-http/src/default_send_request.rs

Lines 96 to 98 in e6b33de

	// at this point, the request contains the scheme and the authority, but
	// the http packet should only include those if addressing a proxy, so
	// remove them here, since SendRequest::send_request does not do it for us

sounds very relevant

[ignatz]

I can confirm that when I add the schema+authority back (

wasmtime/crates/wasi-http/src/default_send_request.rs

Lines 96 to 98 in e6b33de

	// at this point, the request contains the scheme and the authority, but
	// the http packet should only include those if addressing a proxy, so
	// remove them here, since SendRequest::send_request does not do it for us

), at surface level things go back to v47 behavior

[tomasol]

This appears to be related to #14190 , can you try the fix in PR #14191 and confirm whether it resolves your scenario?

[ignatz]

This appears to be related to #14190 , can you try the fix in PR #14191 and confirm whether it resolves your scenario?

Even w/o testing it the fix/workaround is clearly designed to appease:

wasmtime/crates/wasi-http/src/p2/types.rs

Lines 90 to 93 in e6b33de

	None => match parts.headers.get(http::header::HOST) {
	Some(host) => host.to_str()?.to_string(),
	None => bail!("invalid HTTP request missing authority in URI and host header"),
	},

I'm more fundamentally puzzled by the statement:

at this point, the request contains the scheme and the authority, but the http packet should only include those if addressing a proxy, so remove them here,

The default_send_request method is saying: you gave me a request and I will change the request because I know better - why?

[alexcrichton]

I believe this was fixed in #14167 by accident sort of. This was indeed an accidental regression from #13812. Given that this should be fixed on main I'm going to close this. If I've mischaracterized this though please let me know.