add AI-generated unit cases for constant value#4789
Open
kylo5aby wants to merge 1 commit intobytecodealliance:mainfrom
Open
add AI-generated unit cases for constant value#4789kylo5aby wants to merge 1 commit intobytecodealliance:mainfrom
kylo5aby wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
kylo5aby
commented
Jan 16, 2026
kylo5aby
commented
- covers wasm_interp_call_func_bytecode, wasm_runtime_instantiate
- Line coverage: 32.7% → 32.9%
- Function coverage: no change
kylo5aby
requested review from
TianlongLiang,
lum1n0us and
yamt
as code owners
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
4 times, most recently
from
7711ec4 to
83e576e
Compare
lum1n0us
reviewed
Feb 2, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Eventually, I think *fix.md, *review.md, and *verify.md should not be merged. They are process files.
We might need a file to inform future contributors (whether human or AI) about which functions and branches have not been covered, so they can add new cases. This would reduce the workload of analyzing and starting to add new cases.
It could also be a skill or some kind of script.
lum1n0us
added
the
ai-assistant
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
2 times, most recently
from
9d3f96c to
2ea75a4
Compare
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
3 times, most recently
from
c3e64d9 to
97fe879
Compare
Signed-off-by: zhenweijin <zhenwei.jin@intel.com> Co-authored-by: ai-assistant
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
from
97fe879 to
0922f9a
Compare
kylo5aby
force-pushed
the
unit-test-enhance-const
branch
from
0922f9a to
d10426e
Compare
Contributor
Author
|
@lum1n0us @TianlongLiang please take a look |
lum1n0us
reviewed
Mar 11, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Not sure. but seems there's no need to keep all three files: xx_fix.md, xx_review.md, and xx_verify.md.
| ${UNCOMMON_SHARED_SOURCE} | ||
| ) | ||
|
|
||
| # Prepare unit test sources for i64.const test |
| # COMMENT "Copying WASM test files to f64_const test build directory" | ||
| # ) | ||
|
|
||
| include(GoogleTest) |
Contributor
There was a problem hiding this comment.
Better remove this line.
Top-level CMakeLists.txt has done that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.