Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2fa for changing vanities #4

Open
seljux1447 opened this issue Sep 26, 2024 · 3 comments
Open

2fa for changing vanities #4

seljux1447 opened this issue Sep 26, 2024 · 3 comments

Comments

@seljux1447
Copy link

Discord introduced 2fa totp codea required to change vanity urls
Please provide the updated code 🙏

@byigitt
Copy link
Owner

byigitt commented Sep 29, 2024

hmm.. can't you change vanity url without 2fa? (if user doesnt have 2fa, it shouldn't ask) - lmk

@seljux1447
Copy link
Author

hmm.. can't you change vanity url without 2fa? (if user doesnt have 2fa, it shouldn't ask) - lmk

Well that's the catch if user doesn't have 2fa enabled it'll(discord) ask for account password instead

(My opinion is that including a 2FA/MFA mechanism in the code could be straightforward, as the code can automatically generate TOTP codes from a one-time 2FA secret key and use them)

@byigitt
Copy link
Owner

byigitt commented Sep 29, 2024

hmm.. can't you change vanity url without 2fa? (if user doesnt have 2fa, it shouldn't ask) - lmk

Well that's the catch if user doesn't have 2fa enabled it'll(discord) ask for account password instead

(My opinion is that including a 2FA/MFA mechanism in the code could be straightforward, as the code can automatically generate TOTP codes from a one-time 2FA secret key and use them)

i will look into it when I have time, thank you for the information and sorry for the late response!
(if you have the time, you can open up a PR however you want, it would be awesome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants