Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not currently working with 2.4.3 #1

Open
orubel opened this issue Sep 22, 2014 · 6 comments
Open

Not currently working with 2.4.3 #1

orubel opened this issue Sep 22, 2014 · 6 comments

Comments

@orubel
Copy link

orubel commented Sep 22, 2014

commented out tomcat and added this. did a 'clean-all' and then run-app and got error. same with run-war.

error is as follows

No default container found. Please install a container plugin such as 'tomcat' first.

@burtbeckwith
Copy link
Owner

Have you been using this and it no longer works? Or are you just trying it now? After I got it working it didn't seem to be any more performant than using the regular servlet API, so I haven't followed up.

@orubel
Copy link
Author

orubel commented Sep 22, 2014

just tried it. if there's no real perfomance gain, no biggy :)

Owen Rubel
415-971-0976
[email protected]

On Mon, Sep 22, 2014 at 2:52 PM, Burt Beckwith [email protected]
wrote:

Have you been using this and it no longer works? Or are you just trying it
now? After I got it working it didn't seem to be any more performant than
using the regular servlet API, so I haven't followed up.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@orubel
Copy link
Author

orubel commented Sep 22, 2014

all performance gains will come with spring-boot and grails 3 :)

Owen Rubel
415-971-0976
[email protected]

On Mon, Sep 22, 2014 at 2:52 PM, Burt Beckwith [email protected]
wrote:

Have you been using this and it no longer works? Or are you just trying it
now? After I got it working it didn't seem to be any more performant than
using the regular servlet API, so I haven't followed up.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@georges-hatem
Copy link

Hello,
I wasn't sure how to merge the files with my current Grails 2.4.3 app, then I came across this page.
Do you mean that the plugin isn't providing additional performance on new versions of grails anymore?
Thanks!

@burtbeckwith
Copy link
Owner

I only tried it with a couple of recent versions when I was developing it, and didn't see any speed improvement. So it's not worse, which is a good thing. I don't know if I did a fair test though - should compare IO-bound request handling to show that long-running requests don't affect short non-IO bound requests. But we'll be revisiting this as part of Grails 3, basing the core on Spring Boot, adding more Ratpack/Vertx/Node-style options for reactive/async, etc.

But if you find anything in this plugin that's misconfigured and affecting a performance boost let me know; it'd be good to have this as a viable option.

@georges-hatem
Copy link

okay will do, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants