Regression: "Customize Toolbar..." menu

[Grublady]

What were you trying to do?

Upon control-clicking on the title bar and selecting "Customize Toolbar...", it is expected that a menu appears allowing the user to rearrange the toolbar via drag-and-drop.

What was the problem?

Instead, Cork enters an in-between state where:

• Toolbar icons are rearrangeable via drag-and-drop
• The app window is still interactive
• No menu appears

Since toolbar icons are in a rearrangeable state, they cannot be interacted with.
Additionally, since there is no menu, this state cannot be exited without restarting the app.

The problem seems to be related to these two lines:

Cork/Cork/ContentView.swift

Line 165 in 6842ec5

ToolbarItem(id: "maintenance", placement: .secondaryAction)

Cork/Cork/ContentView.swift

Line 171 in 6842ec5

ToolbarItem(id: "manageServices", placement: .secondaryAction)

Setting placement to .primaryAction on both of these reverts the behavior back to a working state.

Error logs

"""
FAULT: NSInternalInconsistencyException: NSToolbar 0x600003931cb0 already contains an item with the identifier maintenance. Duplicate items of this type are not allowed.; {
    NSAssertFile = "NSToolbar.m";
    NSAssertLine = 1621;
}
"""

and

"""
FAULT: NSInternalInconsistencyException: NSToolbar 0x6000022050e0 already contains an item with the identifier manageServices. Duplicate items of this type are not allowed.; {
    NSAssertFile = "NSToolbar.m";
    NSAssertLine = 1621;
}
"""

App Version

1.5, seems to occur as a result of e75a8a5 ("Merge branch 'main.adjusted-toolbar'")

App Acquisition

Self-Compiled

Final checklist

• This report is about the interface, and I included screenshots of the problem

[buresdv]

That's weird, because semantically, both of these should be .secondaryActions. It's also strange why it's complaining about duplicate identifiers, even though they have unique IDs 🤔

[Grublady]

That's weird, because semantically, both of these should be .secondaryActions. It's also strange why it's complaining about duplicate identifiers, even though they have unique IDs 🤔

Agreed 100%, I have no idea why this causes a problem! 😭

For now I'd suggest just reverting it as a quick-fix, and keeping this issue open or opening a new one.
The functionality is non-essential and it could potentially take a while to figure out, so it's probably better to not have it broken in the meantime.