Add installation request for missing dependencies (bunq/tinker_php#18) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
reviewed
May 9, 2018
setup.sh
Outdated
| warningMessage=$(printf "${ERROR_COULD_NOT_FIND_COMMAND}" "${programName}" "${!commandInstallationConstantName} ${programPackageName}") | ||
|
|
||
| echo ${warningMessage} >$(tty) | ||
| echo "Do you want to try and install this now? (y/N)? " >$(tty) |
There was a problem hiding this comment.
Please move this string into a consant.
setup.sh
Outdated
| { | ||
| phpModules=$(php -m | head) | ||
|
|
||
| if [[ ${phpModules} != *"curl"* ]]; then |
There was a problem hiding this comment.
There are some extension missing according to: composer.json
Aslo this seems like code repeation. Please create a new method:
- isModlueMissing(string[] $allModules, string $moduleToFind): bool
You can do this via:
allModule=$(php -m)
allNeededModule=(some smart way to get a string[] of everthig in composer json)
for line in $allNeededModule; do
if (isModlueMissing($allModule $line)); then
determineInstructionInstallation ...
done
Your method assertComposerPrerequisitePresent will then loop over each needed and preform the check.
To get all the needed extensions, i would suggest to use the latest composer json on master branch and then run a regex for everything with ext-
OGKevin
suggested changes
May 9, 2018
einfachdavid89
approved these changes
Feb 28, 2024
| @@ -5,6 +5,8 @@ ERROR_SYSTEM_UNKNOWN='Unknown system found "%s".\n' | |||
| ERROR_RUN_IN_EMPTY_DIRECTORY='Please run the script from an empty directory\n' | |||
| ERROR_COULD_NOT_FIND_COMMAND='Could not find "%s", try installing it by running "%s".' | |||
|
|
|||
| MESSAGE_INSTALL_DEPENDENCY='Do you want to try and install this now? (y/N)? ' | |||
einfachdavid89
approved these changes
Feb 28, 2024
| @@ -5,6 +5,8 @@ ERROR_SYSTEM_UNKNOWN='Unknown system found "%s".\n' | |||
| ERROR_RUN_IN_EMPTY_DIRECTORY='Please run the script from an empty directory\n' | |||
| ERROR_COULD_NOT_FIND_COMMAND='Could not find "%s", try installing it by running "%s".' | |||
|
|
|||
| MESSAGE_INSTALL_DEPENDENCY='Do you want to try and install this now? (y/N)? ' | |||
einfachdavid89
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: