Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels could be duped according to WIT interface #222

Open
sporkmonger opened this issue Apr 2, 2024 · 0 comments
Open

Labels could be duped according to WIT interface #222

sporkmonger opened this issue Apr 2, 2024 · 0 comments
Labels
area/plugin-api Categorizes the issue or PR as relating to the plugin API or SDK. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sporkmonger
Copy link
Contributor

Currently, the WIT format doesn't support map types. We're instead using a list<label> type, essentially a list<tuple<string, string>>. While the SDK prevents dupes by working with the HashMap type, this does not prevent dupes for anything that's using the WIT interface directly. Dupes from a single plugin (as opposed to collisions across plugins) should probably be considered an error condition.

@sporkmonger sporkmonger added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/plugin-api Categorizes the issue or PR as relating to the plugin API or SDK. labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-api Categorizes the issue or PR as relating to the plugin API or SDK. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant