Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Behavior for Multiple Plugins Accessing the Same Redis Keys/Values #205

Open
coderabbitai bot opened this issue Mar 12, 2024 · 0 comments
Open
Labels
good first issue Good first issue for newcomers to the project. kind/docs Categorizes issue or PR as related to documentation.

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2024

There's a need to document how multiple plugins, or instances of the same plugin, can interact with shared Redis keys/values based on their permissions. This aspect is crucial for understanding potential inter-plugin communication and ensuring that the system's behavior aligns with user expectations.

Currently, the documentation on this topic is very light, particularly in the section related to state management and permissions: https://docs.bulwark.security/ops/configuration#state

This issue was raised in the context of a PR discussion, where it was noted that multiple plugins might declare the same permissions for the same keys in Redis, potentially leading to conflicts or unexpected behavior. Specifically, concerns were raised about different expiration windows for rate limiter keys and how they might interfere with each other.

For full context, see the PR and comment discussion here: #202 (comment)

@sporkmonger has requested this documentation update to ensure users are fully informed about how permissions and Redis key/value access work within the Bulwark system.

@sporkmonger sporkmonger added kind/docs Categorizes issue or PR as related to documentation. good first issue Good first issue for newcomers to the project. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issue for newcomers to the project. kind/docs Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

1 participant