Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the devise-two-factor integration to use turbo streams #866

Open
jagthedrummer opened this issue Jun 24, 2024 · 0 comments
Open

Comments

@jagthedrummer
Copy link
Contributor

In this discussion @pascallaliberte said:

Real quick, I'm thinking a slightly larger refactor is recommended. It's probably worth:

  1. replacingcreate.js.erb and other ujs js responses with a turbo response. I'm thinking responding with a turbo-stream update (not replace) of #two-factor's internals using the contents of the devise/registrations/two_factor
  2. replacing the two link_to's in _two_factor.html.erb with button_to to create small proper forms, which will return a turbo_stream as in step 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant