Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependencies on bullet_train-fields #752

Open
jagthedrummer opened this issue Jan 22, 2024 · 2 comments · Fixed by #759
Open

Check dependencies on bullet_train-fields #752

jagthedrummer opened this issue Jan 22, 2024 · 2 comments · Fixed by #759

Comments

@jagthedrummer
Copy link
Contributor

I noticed that some of the other BT gems show up one version behind in the lock file for the fields gem.

https://github.com/bullet-train-co/bullet_train-core/pull/751/files#diff-a43ff21fcd0a4056f0202607a2c49ac32d89dcc3508d9265f1e6437830ba47afL150-R163

@gazayas
Copy link
Contributor

gazayas commented Jan 29, 2024

Currently Up-to-Date Gems

bullet_train-fields (the gem itself)
bullet_train-api
bullet_train-super_scaffolding
bullet_train

Outdated Gems

bullet_train-has_uuid
bullet_train-roles
bullet_train-scope_validator
bullet_train-super_load_and_authorize_resource
bullet_train-themes

TL;DR

The outdated gems listed above are dependencies of bullet_train which was explicitly added later on in #675.

A Brief History

In bullet_train-fields, we added the peer gems bullet_train-api and bullet_train-super_scaffolding in #667 so these have stayed up to date.

You can see that the up-to-date gems mentioned above (besides bullet_train) are listed in #671, but the out of date gems are overlooked in this PR, so this is where they fell behind. Here is a screenshot showing that it's the first version bump after making the changes in #667, so it makes sense that this is where it happened:

image

bullet_train itself is currently up to date though because we explicitly added it shortly thereafter in #675, and you can see the version jump it makes from 1.6.13 to 1.6.15 in this PR.

It looks like things were skipped once again in #682 (the first edit to Gemfile.lock after #675), and then the gems have been on track since.

Because the outdated gems are still being bumped automatically, I think we'll just have to make an explicit version update for those gems to account for the skip that happened, and then we'll be on track.

@jagthedrummer
Copy link
Contributor Author

jagthedrummer commented Feb 7, 2024

Reopening this because it's still an issue.

I just bumped the gems to 1.6.29 but 1.6.28 is still showing up for some of them.

bullet_train-scope_validator (1.6.28)
rails
bullet_train-super_load_and_authorize_resource (1.6.28)
cancancan
rails (>= 6.0.0)
bullet_train-themes (1.6.28)
rails (>= 6.0.0)

I think if we update every Gemfile on every gem in the core lib to point to the local version of any dependency that's declared in the .gemspec then things should keep up to date automatically.

@jagthedrummer jagthedrummer reopened this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants