Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearchitect lazy loading registry cache #818

Open
jromero opened this issue Aug 25, 2020 · 1 comment
Open

Rearchitect lazy loading registry cache #818

jromero opened this issue Aug 25, 2020 · 1 comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@jromero
Copy link
Member

jromero commented Aug 25, 2020

Side tantrum: I have issues with the architecture decision. I'm not seeing the value of lazy loading the cache in this case. I think a better pattern may be to differentiate between a RegistryCache "config" and an "initialized" RegistryCache. Any time a RegistryCache is provided it should already be initialized. A RegistryCacheConfig can be used in cases where we just want to provide configuration without necessary interaction.

Originally posted by @jromero in #782 (comment)

@jromero jromero added this to the 0.14.0 milestone Aug 25, 2020
@jromero jromero added the type/chore Issue that requests non-user facing changes. label Aug 25, 2020
@dfreilich dfreilich added the status/ready Issue ready to be worked on. label Aug 31, 2020
@dfreilich
Copy link
Member

big big 👍 to this. I found the registry cache code very hard to test comprehensively, because of the lazy loading.

@jromero jromero modified the milestones: 0.14.0, 0.15.0 Sep 23, 2020
@jromero jromero modified the milestones: 0.15.0, 0.16.0 Oct 20, 2020
@dfreilich dfreilich modified the milestones: 0.16.0, 0.17.0 Jan 6, 2021
@dfreilich dfreilich modified the milestones: 0.17.0, 0.18.0 Jan 26, 2021
@jromero jromero modified the milestones: 0.18.0, 0.19.0 Mar 10, 2021
@dfreilich dfreilich modified the milestones: 0.19.0, 0.20.0 Jun 15, 2021
@jromero jromero modified the milestones: 0.20.0, 0.21.0 Jul 14, 2021
@jromero jromero removed this from the 0.21.0 milestone Aug 25, 2021
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

No branches or pull requests

3 participants