Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage to acceptance tests #593

Open
jromero opened this issue Apr 22, 2020 · 0 comments
Open

Add code coverage to acceptance tests #593

jromero opened this issue Apr 22, 2020 · 0 comments
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@jromero
Copy link
Member

jromero commented Apr 22, 2020

Description

#591 adds code coverage for unit/integration tests. In order, to truly know the full coverage of our tests we need to add coverage to acceptance tests.

Proposed solution

The proposed solution would apply to pack=current, create builder pack=current, lifecycle=default when pack itself is built by the acceptance tests. A possible solution could be that instead of it being built to binary, a wrapper/interface could be created that does "magic" when calling operations to pack.

I propose this "hack" because it appears that go run -cover or go build -cover don't exist. The implementation should be a tidy as possible limiting the scope of the "hack" to a very specific section of code.

Additional context

@jromero jromero added type/chore Issue that requests non-user facing changes. status/ready Issue ready to be worked on. labels Apr 22, 2020
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

No branches or pull requests

2 participants