Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack build should fail when the specified image is already building #407

Open
sclevine opened this issue Dec 6, 2019 · 1 comment
Open
Labels
help wanted Need some extra hands to get this done. size/md Medium level of effort status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.

Comments

@sclevine
Copy link
Member

sclevine commented Dec 6, 2019

Note: if we use a file to implement this, we should grab a lock on the file. Don't just use file presence to determine whether the image is locked. You should be able to kill -9 pack without leaving the image locked.

@jromero jromero added size/md Medium level of effort type/enhancement Issue that requests a new feature or improvement. labels Dec 9, 2019
@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano
Copy link
Member

Possible acceptance criteria:

When I run pack build some-image
And I run pack build some-image again while the previous invocation is still running
Then I should get a helpful error message

When I run pack build some-image
And I kill -9 pack (or the equivalent on Windows)
Then I should be able to run pack build some-image again without error

@natalieparellano natalieparellano added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Feb 5, 2020
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. size/md Medium level of effort status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants