Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blob for AppPath option #286

Open
jromero opened this issue Sep 9, 2019 · 0 comments
Open

Use blob for AppPath option #286

jromero opened this issue Sep 9, 2019 · 0 comments
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@jromero
Copy link
Member

jromero commented Sep 9, 2019

Now that we have blobs, it makes sense to use it for "AppPath" as a way to abstract input information to build from. The value being that it streams data from multiple source types such as tar, tgz and dir. Additionally, we could effectively add zip (jar) with little effort and it take effect
across all input types (buildpacks, lifecycle and app).

Proposed Solution

blob.New(path string, strict bool)

Goals

  • Centralize input source traversing
  • Enforce restrictions based on conditions such as source and platform (see below)

Additional considerations

  • Incorporate support for additional compression formats (zip)
  • Chmod 0777 when strict=false and path is dir on Windows

Prior Art

We have abstracted the inputs of layer information for buildpacks and the lifecycle into a new concept called blobs.

Windows Dir Restriction

I feel like this type of logic belongs in the blob package. The idea was to encapsulate all logic about data formats in that package.

For now it looks like directory blobs are never allowed on windows (b/c of the perm issues). If we wanted to support directory blobs for an app dir or adding a buildpack at build time we could create strict and non-strict blob constructor options to that package.

Originally posted by @ekcasey in #279

@jromero jromero added the type/chore Issue that requests non-user facing changes. label Sep 9, 2019
@jromero jromero changed the title Use blob for AppDir option Use blob for AppPath option Sep 9, 2019
@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano natalieparellano added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Feb 5, 2020
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

No branches or pull requests

2 participants