Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: reset classes applied twice on Link component #829

Open
kevinkucharczyk opened this issue Feb 22, 2024 · 0 comments
Open

Bug: reset classes applied twice on Link component #829

kevinkucharczyk opened this issue Feb 22, 2024 · 0 comments
Labels
bug Something isn't working triage-needed

Comments

@kevinkucharczyk
Copy link

Description of the bug

You can see this in Storybook: https://storybook.bento-ds.com/?path=/story/components-link--link

The component renders as

<a tabindex="0" role="link" target="_blank" href="http://www.example.com" class="_1sg6ssb0 _1sg6ssb6 _1sg6ssb0 fmzr143 oc4xku1aw oc4xku1ba oc4xku1fc oc4xku1w0 oc4xku1vy oc4xku1w1 oc4xku1w2 oc4xku1w4 oc4xkur6 oc4xkurc oc4xkuri oc4xkurp paq9lr2 oc4xku30 paq9lr4 _1sg6ssb6 _1fef0ld3w">I'm a link</a>

The classes of _1sg6ssb0 (the base reset) and _1sg6ssb6 (the a reset) exist twice.
It's not really a big deal, but if this could be avoided it would generate slightly less verbose class strings, which makes it easier for humans to read and debug.

Playroom reproduction

No response

Version

0.22.6

What browsers are you seeing the problem on?

Chrome, Safari, Firefox, Edge

@kevinkucharczyk kevinkucharczyk added bug Something isn't working triage-needed labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage-needed
Projects
None yet
Development

No branches or pull requests

1 participant