Expose ref of components #314
Assignees
Comments
|
I think we should split this in smaller chunks of work, the first piece of work would be listing the components we want to expose the ref of (I.e. a list with checkboxes in this issue) and then start working on a component-per-component basis |
|
List of components:
|
|
I had a look at what MUI does for their components that have an equivalent in Bento, and it looks to me that the default behaviour is always forwarding the |
|
There are cases in which there are multiple refs. E.g. https://mui.com/material-ui/api/input/ has an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apart from
Box, we currently don't forward therefprop of any of the components. This is rather arbitrary and potentially problematic in some situations.For example, we can't use a
Buttondirectly as a trigger forMenusince it doesn't accept aref.As another example, users of Bento can't programmatically control focus on the components in case they need to, and so on.
This is issue is potentially broad, but I propose we expose
refon every component. Where to forwardrefheavily depends on the component itself: in some cases it may make sense to target the top-level wrapper of the component, in other cases we may need to target the native component we're wrapping (think ofNumberInputfor instance).The text was updated successfully, but these errors were encountered: