Upload: clearer, non-repeating error message wrapping

pda · pda · commit 355debd19900 · 2025-03-20T12:01:15.000+13:00
Before:

    2025/03/20 12:00:46 INFO Uploading key=0195b0a3-49bf-7812-af95-ff7ef0e6ff4d format=junit filename=test.xml
    Buildkite Test Engine Client: upload: Upload: opening test.xml for reading: open test.xml: permission denied

After:

    2025/03/20 12:00:46 INFO Uploading key=0195b0a3-49bf-7812-af95-ff7ef0e6ff4d format=junit filename=test.xml
    Buildkite Test Engine Client: upload: preparing upload data: opening test.xml for reading: open test.xml: permission denied
diff --git a/internal/upload/upload.go b/internal/upload/upload.go
@@ -101,7 +101,7 @@ func UploadCLI(flag *flag.FlagSet, env env.Env) error {
 func Upload(ctx context.Context, cfg Config, runEnv RunEnvMap, format string, filename string) (map[string]string, error) {
 	body, err := buildUploadData(runEnv, format, filename)
 	if err != nil {
-		return nil, fmt.Errorf("Upload: %w", err)
+		return nil, fmt.Errorf("preparing upload data: %w", err)
 	}
 
 	req, err := http.NewRequestWithContext(

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ func UploadCLI(flag *flag.FlagSet, env env.Env) error {`
`101`	`101`	`func Upload(ctx context.Context, cfg Config, runEnv RunEnvMap, format string, filename string) (map[string]string, error) {`
`102`	`102`	`body, err := buildUploadData(runEnv, format, filename)`
`103`	`103`	`if err != nil {`
`104`		`- return nil, fmt.Errorf("Upload: %w", err)`
	`104`	`+ return nil, fmt.Errorf("preparing upload data: %w", err)`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`req, err := http.NewRequestWithContext(`