Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source map support #28

Open
robink opened this issue Jun 5, 2014 · 6 comments
Open

Add source map support #28

robink opened this issue Jun 5, 2014 · 6 comments
Assignees

Comments

@robink
Copy link

robink commented Jun 5, 2014

I believe it would be very nice to support source maps.

@robink
Copy link
Author

robink commented Jul 9, 2014

Hey @DamonOehlman , do you think it could be feasible ? If so, I could try to take a look at it.

@DamonOehlman
Copy link
Member

@robink - Sorry for the delay in getting back to you, was on a weeks holiday :)

I do think it would be possible, and it would be great if you wanted to take a crack at implementing it. Let me take a look at the code in the next couple of days and I'll provide you my thoughts about how you might go about it...

@ivangretsky
Copy link

Good day! Thanks for the project!

I got rigger concatenating js partials files on my gulp-based project. I got gulp-sourcemaps included in the pipeline. But in the browser dev tools I still see errors spotted only in main.js (no matter where I put sourcemaps.init(): before or after rigger().

Is this the same question? Is there any solution to this?

@DamonOehlman
Copy link
Member

I think it probably is. From my reading, the gulp-sourcemaps plugin creates a sourcemap from the various packaging based on it's glob patterns. Were you using the gulp-rigger plugin?

If it was possible to use the gulp-sourcemaps package to get sourcemap support rather than trying to get rigger to do it, then that would be ideal. From having a quick look at the source though it's heavily reliant on the use of the "vinyl files" that the are emitted from the gulp.src call.

I think to get sourcemap support in rigger it would have to be manually implemented. It's one of those things I feel guilty for not doing, so I reckon I should just bite the bullet and make it work. If rigger is still useful to you in your work, then I'm more than happy to do that :)

Feel free to ping me if I go quiet...

@DamonOehlman DamonOehlman self-assigned this Sep 6, 2017
@ivangretsky
Copy link

As far as I know rigger is still widely used in Russia due to this article. So some kind of source maps support will be quite nice.

@olytv
Copy link

olytv commented Jan 13, 2018

I join the request! Now in order to compile js with sourcemap saving it is necessary to specify the paths in gulpfile.js. It will be more obvious if you specify paths directly in a file similar to main.js using rigger.
Thanks for the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants