Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Customize setting the resources on the rbac-proxy container #82

Closed
DeviaVir opened this issue Dec 30, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@DeviaVir
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It looks like because we are not currently setting any resource requests/limits, some (looking at you GKE) schedulers come up with crazy (expensive) numbers like:

        resources:
          limits:
            cpu: 500m
            ephemeral-storage: 1Gi
            memory: 2Gi
          requests:
            cpu: 500m
            ephemeral-storage: 1Gi
            memory: 2Gi

Describe the solution you'd like

Since we want to stay away of setting defaults, let's at least make it possible to customize these values.

Describe alternatives you've considered

Considered investigating if autopilot.gke.io/primary-container could help with this, but it already says it applies to the first container (which is the tor-controller already)

Additional context

Screenshot 2024-12-30 17 58 46

@bugfest
Copy link
Owner

bugfest commented Dec 30, 2024

Fixed by #83

@bugfest bugfest closed this as completed Dec 30, 2024
@DeviaVir
Copy link
Contributor Author

Screenshot 2024-12-31 10 46 41
Glorious. Thank you for the swift turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants