repeated field validation along with item specific validations

[Shivam010]

Hi, I want to check the unique and min_items validations along with the corresponding item validation in GoLang, but in doing so, I am getting an error:

Error while parsing option value for "repeated": Expected "{", found ".".

using:

message One {
     repeated string str = 1 [(validate.rules).repeated = {
        unique: true
        min_items: 1
        items.string: {
            min_len: 3
            max_len: 10
        }
    }];
}

---

And using something like passing more than one options for a field, I am getting another error:

Option "(validate.rules).repeated" was already set.

using:

message Two {
    repeated string str = 1 [(validate.rules).repeated.items.string = {min_len: 3 max_len: 10}, (validate.rules).repeated = {unique: true min_items: 1}];
}

---

Also, passing more than one validate field options in the array only uses the last one only.

message Three {
    repeated string str = 1 [(validate.rules).repeated.unique = true, (validate.rules).repeated.min_items = 1];
}

For object Three, only min_items validation will be generated.

---

Am I missing something or are these bugs?

[akonradi]

Your first try is mostly right, just a small syntax error. Try this instead:

message One {
     repeated string str = 1 [(validate.rules).repeated = {
        unique: true
        min_items: 1
        items: {
            string: {
                min_len: 3
                max_len: 10
            }
        }
    }];
}

[Shivam010]

Yes, my bad. I missed the basic syntax. Thanks @akonradi
But what about the validations in message Three?

[akonradi]

I think you'll also need to use the expanded syntax to set more than one field. Try this:

message Three {
    repeated string str = 1 [(validate.rules).repeated = {
        unique: true
        min_items: 1
    }];
}

[Shivam010]

Means, the plugin does not handle more than one options in the proto-options-array
Ok cool, I was asking out of curiosity, I don't think that would be required.
Thanks again

[rodaine]

Means, the plugin does not handle more than one options in the proto-options-array

This is a limitation of the protoc parser it turns out; you're essentially creating a new repeated message there in the annotation.

[Shivam010]

This is a limitation of the protoc parser it turns out; you're essentially creating a new repeated message there in the annotation.

I think it is the limitation in protoc-gen-star, I tried a simple example with these options: link.
And used them in the same way as in above message Three: link.
And print the values in all the options here.

It turns out that in the case of oneOf a new message is created each time. And hence, it is not working in protoc-gen-validate

I have opened an issue in protoc-gen-star on this lyft/protoc-gen-star#64

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.