Add buf convert --disallow-unknown #3115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
|
This was just a drive-by PR and it's actually wrong. This adjusts the default behavior for binary and text formats to discard unknown values, which breaks a lot of things in unexpected ways. For some reason, we had discard unknown default to true for JSON, false for wire and txtpb, and implicitly false for yaml. This was likely a decision I made a long time ago. This PR will need to be significantly adjusted to not introduce breaking changes. |
|
Closing this for now - this PR is seriously off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins #2714. See bufbuild/protoyaml-go#37 for the remaining work for YAML that once fixed, can resolve the aforementioned issue.