Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing up error messages in bufconfig #3257

Open
doriable opened this issue Aug 21, 2024 · 0 comments
Open

Clearing up error messages in bufconfig #3257

doriable opened this issue Aug 21, 2024 · 0 comments
Assignees
Labels
Cleanup Cleanup tasks

Comments

@doriable
Copy link
Member

GitHub Repository

N/A

Commands

$ buf generate

Output

# rm -rf gen && buf generate --template buf.directory.invalid.gen.yaml && tree gen
Failure: decode config file: option branch is not allowed for InputConfigType directory
18:17

# buf generate
Failure: decode buf.gen.yaml: invalid as version v2: could not unmarshal as YAML: yaml: unmarshal errors:
  line 10: field option not found in type bufconfig.externalManagedOverrideConfigV2

Expected Output

This case came up for buf generate, but this a general note on the errors when handling configs -- we are returning the marshal/unmarshal errors, which leak some internal types (e.g. InputConfigType), which may not be helpful to the user. We may want to rework these error messages.

Anything else?

No response

@doriable doriable added the Bug Something isn't working label Aug 21, 2024
@doriable doriable self-assigned this Aug 21, 2024
@doriable doriable added Cleanup Cleanup tasks and removed Bug Something isn't working labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleanup tasks
Projects
None yet
Development

No branches or pull requests

1 participant