Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import should add, not overwrite #38

Open
strider72 opened this issue Oct 7, 2015 · 2 comments
Open

Import should add, not overwrite #38

strider72 opened this issue Oct 7, 2015 · 2 comments

Comments

@strider72
Copy link

I had a bunch of quicktags in Settings. I tested an import file, and rather than adding the new tag, it completely erased anything that already existed, leaving only the imported tag. It also saved the settings as such so there was no way to undo.

One of two things should change here: Either give the user an explicit option to add or overwrite, OR the plugin should not immediately save the options, so the user can "undo" by leaving the Settings page without saving.

@bueltge
Copy link
Owner

bueltge commented Oct 8, 2015

Hi @strider72
right, currently is the import a full overwrite of the settings, no checks for existing settings.

That I understand right. You will add new settings from a other installation, additional settings to current settings.

@strider72
Copy link
Author

Correct. When I import, it should add the new settings to existing settings. It should not remove the existing settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants