Set up Rubocop

Author: infertux

.rubocop.yml

@@ -0,0 +1,20 @@
+Metrics:
+  Enabled: false
+
+Style/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+Style/Documentation:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: comma

Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in buckybox-api.gemspec
 gemspec

Rakefile

@@ -3,4 +3,4 @@ require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

buckybox-api.gemspec

@@ -1,13 +1,13 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "buckybox-api"
   spec.version       = "1.6.2"
   spec.authors       = ["Cédric Félizard"]
   spec.email         = ["[email protected]"]
-  spec.summary       = %q{RubyGem wrapper for the Bucky Box API}
+  spec.summary       = "RubyGem wrapper for the Bucky Box API"
   spec.description   = "#{spec.summary} - https://api.buckybox.com/docs"
   spec.homepage      = ""
   spec.license       = "LGPLv3"
@@ -26,5 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", ">= 3.5"
   spec.add_development_dependency "vcr"
   spec.add_development_dependency "webmock"
-  spec.add_development_dependency "simplecov", ">= 0.9"
+  spec.add_development_dependency "simplecov", ">= 0.11"
+  spec.add_development_dependency "rubocop"
 end

lib/buckybox/api.rb

@@ -39,11 +39,11 @@ def initialize(headers)
       self.class.headers(headers)
     end
 
-    def boxes(params = {embed: "images"}, options = {})
+    def boxes(params = { embed: "images" }, options = {})
       query :get, "/boxes", params, options, price: CrazyMoney
     end
 
-    def box(id, params = {embed: "extras,images,box_items"}, options = {})
+    def box(id, params = { embed: "extras,images,box_items" }, options = {})
       query :get, "/boxes/#{id}", params, options, price: CrazyMoney
     end
 
@@ -74,7 +74,7 @@ def authenticate_customer(params = {}, options = {})
     def create_or_update_customer(json_customer)
       customer = JSON.parse(json_customer)
 
-      if customer['id']
+      if customer["id"]
         query :put, "/customers/#{customer['id']}", json_customer # TODO: replace by :patch
       else
         query :post, "/customers", json_customer
@@ -108,26 +108,26 @@ def exception_type(http_code)
 
     def query(type, uri, params = {}, options = {}, types = {})
       options = {
-        as_object: true
+        as_object: true,
       }.merge(options)
 
       hash = query_cache(type, uri, params, types)
 
       if options[:as_object]
-        SuperRecursiveOpenStruct.new(hash)
+        Response.new(hash)
       else
         hash
       end.freeze
     end
 
     def query_cache(type, uri, params, types)
-      query_fresh = -> {
+      query_fresh = lambda do
         params_key = (type == :get ? :query : :body)
         response = self.class.public_send(type, uri, params_key => params)
         check_response!(response)
         parsed_response = response.parsed_response
         add_types(parsed_response, types)
-      }
+      end
 
       if type == :get # NOTE: only cache GET method
         @cache ||= {}
@@ -163,7 +163,7 @@ def add_types(object, types)
 
     def to_query(hash)
       if hash.empty?
-        ''
+        ""
       else
         hash.map do |key, value|
           "#{CGI.escape(key.to_s)}=#{CGI.escape(value)}"

spec/spec_helper.rb

@@ -65,7 +65,7 @@
     # Use the documentation formatter for detailed output,
     # unless a formatter has already been configured
     # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
+    config.default_formatter = "doc"
   end
 
   # Print the 10 slowest examples and example groups at the
@@ -88,10 +88,9 @@
 
 require "vcr"
 VCR.configure do |c|
-  c.cassette_library_dir = 'fixtures'
+  c.cassette_library_dir = "fixtures"
   c.hook_into :webmock
   c.configure_rspec_metadata!
-  c.filter_sensitive_data('<API-Key>') { ENV.fetch("BUCKYBOX_API_KEY") }
-  c.filter_sensitive_data('<API-Secret>') { ENV.fetch("BUCKYBOX_API_SECRET") }
+  c.filter_sensitive_data("<API-Key>") { ENV.fetch("BUCKYBOX_API_KEY") }
+  c.filter_sensitive_data("<API-Secret>") { ENV.fetch("BUCKYBOX_API_SECRET") }
 end
-