Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-3655 Apple Pay functionality #29

Open
elzekool opened this issue Jul 12, 2024 · 4 comments
Open

BP-3655 Apple Pay functionality #29

elzekool opened this issue Jul 12, 2024 · 4 comments
Assignees
Labels
Bug Bugs, functions that are not working like they should. Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet.

Comments

@elzekool
Copy link

For one of our clients we want to implement Apple Pay however we noticed that the implementation had some issues. I am wondering if this is something that is known and on the radar to fix.

One issue we found during debugging is that in the method register() the method checkPaySupport() is called without a merchan tIdentifier (https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/view/frontend/templates/component/payment/after.phtml#L262) while the original method defined in https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/view/frontend/web/js/applepay.js#L15 requires it. This is an issue we could fix with providing this.config.guid to the BuckarooApplePay.checkPaySupport() method.

However that leaded to a situation where there first appears an unstyled payment link ("Plaats bestelling" = "Place order" in Dutch):
image

And only after clicking that an Apple Pay button appears which also has a broken styling:
image

Our expectations were that the customer selects Apple Pay and then continue placing the order and if Apple Pay is not supported the method is not visible. Currently two situations happen:

@Buckaroo-Rene Buckaroo-Rene changed the title Apple Pay functionality BP-3655 Apple Pay functionality Jul 12, 2024
@Buckaroo-Rene Buckaroo-Rene added the Priority: Normal This issue has a normal/medium priority. label Jul 12, 2024
@Buckaroo-Rene
Copy link
Contributor

Goodmorning @elzekool ,

Thank you for contacting us about this issue. We'll take a look at this

Just to be sure, did you also register the domain in the Buckaroo Plaza as well?
This is needed for Apple Pay, also to host the Apple Pay Domain Association file as written on the Apple Pay configuration page in the Buckaroo Plaza.

image

@elzekool
Copy link
Author

elzekool commented Jul 12, 2024

Hey @Buckaroo-Rene ,

Yes, that is configured. Not entirely sure how it works between Buckaroo and Apple but I imagine that Buckaroo configures a merchant with Apple Pay with the Buckaroo GUID.

At least that what I think is happening in the regular Magento 2 module at https://github.com/buckaroo-it/Magento2/blob/master/view/frontend/web/js/view/checkout/applepay/pay.js#L69, there BuckarooSdk.ApplePay.checkApplePaySupport is called with window.checkoutConfig.payment.buckaroo.applepay.guid the definition of this function in https://checkout.buckaroo.nl/api/buckaroosdk/script is the same as the function defined in https://github.com/buckaroo-it/Magento2_Hyva_Checkout/blob/master/view/frontend/web/js/applepay.js#L15.

@sanderjongsma
Copy link

sanderjongsma commented Oct 9, 2024

any update on this? @elzekool did you manage to create a solution? We also encounter the same issue with the buttons on top of eachother
Screenshot from 2024-10-09 12-32-22

@Buckaroo-Rens
Copy link

@sanderjongsma / @elzekool we are looking into a solution for this.

@Buckaroo-Rens Buckaroo-Rens added the Bug Bugs, functions that are not working like they should. label Oct 18, 2024
@Buckaroo-Rene Buckaroo-Rene added the Status: Waiting for release This issue has been solved, but is not released yet. label Dec 10, 2024
@Buckaroo-Rene Buckaroo-Rene self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs, functions that are not working like they should. Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet.
Projects
None yet
Development

No branches or pull requests

4 participants