You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue addresses the content-container-narrow class applied to templates indicated in the documentation and when using the "Keep posts sidebar on bottom" settings in the customizer.
Currently the content-container-narrow class is implemented via PHP and styled via CSS in the framework which requires a filter to remove the templates from the array. While this may have been necessary when the framework was initially developed we may want to consider removing the the application of such a class from the framework all together and allow designers/FE developers to apply the class to the templates they see fit to do so.
By allowing the designer control of the content area from the theme level we can
Follow a mobile + responsive approach
Reduce the specificity CSS required within the child theme
Eliminates overriding each template that applies the class
Eliminates the need to track pages using the "Keep posts sidebar on bottom"
Other considerations
When considering the updating of this approach we should also evaluate ALL template layouts and what we can eliminate from the framework for modern browsers. Today's modern browsers and WP support indicate that we can consider
Removal of floats in favor of a CSS grid approach
Removing many of the Modernizr checks
Removing many browser specific prefixes
The need to include any IE specific stylesheets
Application of a sidebar location class for each template on the body
Describe the solution you'd like
Solutions to come.
The text was updated successfully, but these errors were encountered:
Description
This issue addresses the
content-container-narrow
class applied to templates indicated in the documentation and when using the "Keep posts sidebar on bottom" settings in the customizer.Currently the
content-container-narrow
class is implemented via PHP and styled via CSS in the framework which requires a filter to remove the templates from the array. While this may have been necessary when the framework was initially developed we may want to consider removing the the application of such a class from the framework all together and allow designers/FE developers to apply the class to the templates they see fit to do so.By allowing the designer control of the content area from the theme level we can
Other considerations
When considering the updating of this approach we should also evaluate ALL template layouts and what we can eliminate from the framework for modern browsers. Today's modern browsers and WP support indicate that we can consider
Describe the solution you'd like
Solutions to come.
The text was updated successfully, but these errors were encountered: