Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow template class removal #292

Open
saucyrooster opened this issue Mar 11, 2022 · 0 comments
Open

Narrow template class removal #292

saucyrooster opened this issue Mar 11, 2022 · 0 comments

Comments

@saucyrooster
Copy link

Description

This issue addresses the content-container-narrow class applied to templates indicated in the documentation and when using the "Keep posts sidebar on bottom" settings in the customizer.

Currently the content-container-narrow class is implemented via PHP and styled via CSS in the framework which requires a filter to remove the templates from the array. While this may have been necessary when the framework was initially developed we may want to consider removing the the application of such a class from the framework all together and allow designers/FE developers to apply the class to the templates they see fit to do so.

By allowing the designer control of the content area from the theme level we can

  • Follow a mobile + responsive approach
  • Reduce the specificity CSS required within the child theme
  • Eliminates overriding each template that applies the class
  • Eliminates the need to track pages using the "Keep posts sidebar on bottom"

Other considerations

When considering the updating of this approach we should also evaluate ALL template layouts and what we can eliminate from the framework for modern browsers. Today's modern browsers and WP support indicate that we can consider

  • Removal of floats in favor of a CSS grid approach
  • Removing many of the Modernizr checks
  • Removing many browser specific prefixes
  • The need to include any IE specific stylesheets
  • Application of a sidebar location class for each template on the body

Describe the solution you'd like

Solutions to come.

@saucyrooster saucyrooster changed the title Narrow template removal Narrow template class removal Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants