Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Activation #222

Open
5 tasks done
mustafauysal opened this issue Jul 9, 2020 · 5 comments
Open
5 tasks done

Responsive Activation #222

mustafauysal opened this issue Jul 9, 2020 · 5 comments
Assignees
Labels
10up_id_product_development Work related to the 10up ID Product development project.

Comments

@mustafauysal
Copy link

mustafauysal commented Jul 9, 2020

@mustafauysal mustafauysal added the 10up_id_product_development Work related to the 10up ID Product development project. label Jul 9, 2020
@mustafauysal
Copy link
Author

bu-site-init.php https://github.com/bu-ist/responsive-framework/blob/develop/bu-site-init.php - the child theme can handle the init instead of the parent

@ashleykolodziej It seems theme-specific initializer strictly tied to the template file. - https://github.com/bu-ist/site-manager/blob/master/lib/api.php#L89

We can use after_switch_theme or plugin activation hook with the custom plugin. However, it can possibly be triggered more than once (let's say you switch theme later on) and raise problems such as deleting the published contents.

IMO, https://github.com/bu-ist/site-manager would be a better home for this functionality.

thoughts?

@ashleykolodziej
Copy link
Contributor

I think this makes sense. I'm going to see if I can find someone on the webteam to help us out and double check our plan. As long as this is done in a way that only affects Responsive 3x, I think we'll be in good shape. :)

@ashleykolodziej
Copy link
Contributor

Couple of sites you can test this against:

To test:

  • Switch themes
  • Double check sidebars are the same/have the same widgets
  • Site name, content, etc. should be roughly the same

@mustafauysal
Copy link
Author

@ashleykolodziej Thanks for setting up the test sites.

I've cloned them and activated the custom plugin and Responsive Framework 3x

Reference Test Site
http://10up-responsi.cms-devl.bu.edu/flexi/ http://10up-responsi.cms-devl.bu.edu/test-flexi-222/
http://10up-responsi.cms-devl.bu.edu/responsi-1x/ http://10up-responsi.cms-devl.bu.edu/test-responsi-1x-222/
http://10up-responsi.cms-devl.bu.edu/responsi-2x/ http://10up-responsi.cms-devl.bu.edu/test-responsi-2x-222/

I've also created a new website for testing theme initialization (removing default contents, adding menu items etc..) is working as expected. - http://10up-responsi.cms-devl.bu.edu/cleantest/

@mustafauysal
Copy link
Author

Let's keep this open till https://github.com/bu-ist/site-manager/pull/11 get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10up_id_product_development Work related to the 10up ID Product development project.
Projects
None yet
Development

No branches or pull requests

2 participants