Skip to content

Commit 31ab867

Browse files
committed
Linting
Modernize tests
1 parent c0b5f16 commit 31ab867

29 files changed

+261
-285
lines changed

.editorconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,5 @@ insert_final_newline = true
1212
indent_style = space
1313
indent_size = 2
1414

15-
[*.hbs]
16-
insert_final_newline = false
17-
1815
[*.{diff,md}]
1916
trim_trailing_whitespace = false

ember-simple-tree/.prettierrc.cjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ module.exports = {
66
{
77
files: '*.{js,gjs,ts,gts,mjs,mts,cjs,cts}',
88
options: {
9+
printWidth: 120,
910
singleQuote: true,
1011
templateSingleQuote: false,
1112
},

ember-simple-tree/eslint.config.mjs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,7 @@ export default [
7474
* CJS node files
7575
*/
7676
{
77-
files: [
78-
'**/*.cjs',
79-
'.prettierrc.js',
80-
'.stylelintrc.js',
81-
'.template-lintrc.js',
82-
'addon-main.cjs',
83-
],
77+
files: ['**/*.cjs', '.prettierrc.js', '.stylelintrc.js', '.template-lintrc.js', 'addon-main.cjs'],
8478
plugins: {
8579
n,
8680
},

ember-simple-tree/src/components/x-tree-branch.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@
3737
{{/if}}
3838
{{/if}}
3939
{{/each}}
40-
</ul>
40+
</ul>
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
<span class="tree-checkbox">
22
<span role="button" {{on "click" @toggleCheck}}>
3-
<Input
3+
{{! template-lint-disable no-invalid-role no-nested-interactive }}
4+
<input
45
aria-label="Checkbox for {{@model.name}}"
6+
checked={{@model.isChecked}}
57
disabled={{@model.isDisabled}}
68
indeterminate={{@model.isIndeterminate}}
79
role="presentation"
8-
@checked={{@model.isChecked}}
9-
@type="checkbox"
10+
type="checkbox"
1011
/>
1112
</span>
12-
</span>
13+
</span>

ember-simple-tree/src/components/x-tree-children.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,4 @@
6969
/>
7070
{{/if}}
7171
{{/if}}
72-
</li>
72+
</li>

ember-simple-tree/src/components/x-tree-children.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ export default class TreeChildrenComponent extends Component {
1111
let isChecked = false;
1212
let isIndeterminate = false;
1313

14-
if (children.every(x => x.isChecked)) {
14+
if (children.every((x) => x.isChecked)) {
1515
isChecked = true;
16-
} else if (children.some(x => x.isChecked || x.isIndeterminate)) {
16+
} else if (children.some((x) => x.isChecked || x.isIndeterminate)) {
1717
isIndeterminate = true;
1818
}
1919

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
&#x25B6;
1+
&#x25B6;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
&#x25BC;
1+
&#x25BC;

ember-simple-tree/src/components/x-tree-node.hbs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
{{yield
1111
(hash
1212
model=@model
13-
toggle=(component "x-tree-toggle"
13+
toggle=(component
14+
"x-tree-toggle"
1415
model=@model
1516
toggleExpand=this.toggleExpand
1617
expandedIcon=@expandedIcon
1718
collapsedIcon=@collapsedIcon
1819
)
19-
checkbox=(component "x-tree-checkbox"
20-
model=@model
21-
toggleCheck=this.toggleCheck
20+
checkbox=(component
21+
"x-tree-checkbox" model=@model toggleCheck=this.toggleCheck
2222
)
2323
)
2424
}}
@@ -42,4 +42,4 @@
4242
{{@model.name}}
4343
</span>
4444
{{/if}}
45-
</div>
45+
</div>

0 commit comments

Comments
 (0)