Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When non-loadable projects are found and skipped they should still be reported #48

Closed
WangleLine opened this issue Apr 7, 2023 · 4 comments
Labels
✨ feature New feature or request

Comments

@WangleLine
Copy link

WangleLine commented Apr 7, 2023

It's a Gamemaker project from around 2020, not sure which version (yyp doesn't seem to contain the ide or runtime versions)
https://drive.google.com/file/d/1wzjDCJrwBRYU93WNzgiU3bCSVC3lZZsH/view?usp=sharing

Stitch_HmVJNanXCr

@adam-coster
Copy link
Member

Stitch has no nuance when it comes to finding projects and reporting whether or not it found any.

It basically scans for .yyp files starting from the folder you specify, and then checks each one it finds to see if it matches the expected format for recent GameMaker versions. It just skips .yyp files that don't match that format, rather than reporting any errors.

To keep Stitch maintainable we try to keep its features compatible with the latest versions of GameMaker without also trying to maintain backwards compatibility.

@WangleLine
Copy link
Author

Oh yeah I wasn't super expecting it to work with versions this old, but the message it returned felt wrong

@adam-coster
Copy link
Member

@WangleLine Yeah you're totally right about that! It really should show some sort of indication that it found project files but couldn't load them.

@adam-coster adam-coster changed the title Trying to add this specific old project fails, but Stitch still shows the successful "Search Complete!" message "Search Complete!" message is confusing when old projects were found but skipped Apr 17, 2023
@adam-coster adam-coster added the ✨ feature New feature or request label Apr 17, 2023
@adam-coster adam-coster changed the title "Search Complete!" message is confusing when old projects were found but skipped When non-loadable projects are found and skipped they should still be reported Apr 17, 2023
@adam-coster
Copy link
Member

Closing due to deprecation of Stitch Desktop in favor of Stitch for VSCode.

See #138 for details.

(Note that the VSCode extension does provide a warning when a project was found but could not be loaded!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants