Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar is not inserted because 304 is not "ok?" #30

Open
ghazel opened this issue Dec 1, 2010 · 1 comment
Open

toolbar is not inserted because 304 is not "ok?" #30

ghazel opened this issue Dec 1, 2010 · 1 comment

Comments

@ghazel
Copy link

ghazel commented Dec 1, 2010

When I click the bookmarklet and type my password, the toolbar does not appear. Hard-refreshing the page makes the toolbar appear.

Digging in to the source, I see that @response.ok? returns false, because the status code is 304 (Not Modified) instead of 200. One way around this I used was to strip "HTTP_IF_NONE_MATCH" from the env before passing on the request, so the etag would not match.

@ghazel
Copy link
Author

ghazel commented Dec 1, 2010

#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant