Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-modular JavaFX projects #1

Open
shathor opened this issue Feb 24, 2019 · 4 comments
Open

Non-modular JavaFX projects #1

shathor opened this issue Feb 24, 2019 · 4 comments

Comments

@shathor
Copy link

shathor commented Feb 24, 2019

This starter won't work for non-modular projects. The main method should be in a class that doesn't extend Application for now. See http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-June/021977.html

@brunoborges
Copy link
Owner

This starter is not intended, for now, to work with non-modular projects. But will keep this in mind.

If you can enhance it to do so, happy to review a PR.

@shathor
Copy link
Author

shathor commented Feb 24, 2019

Hardly any projects are modular in JPMS sense and there's no sign that the industry will catch on, so I think there's more value when it also works for non-modular projects.

@brunoborges
Copy link
Owner

Fair statement. I'll investigate further!

@siordache
Copy link

siordache commented Feb 25, 2019

@brunoborges This example is a good starting point for implementing a non-modular JavaFX starter project.

@shathor See this FXGL implementation of Pacman for an example of creating a custom runtime image for a complex non-modular JavaFX project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants