Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File::Temp::HIGH setting causes t931 test to fail #1669

Closed
veprbl opened this issue Oct 3, 2021 · 3 comments · Fixed by #1682
Closed

File::Temp::HIGH setting causes t931 test to fail #1669

veprbl opened this issue Oct 3, 2021 · 3 comments · Fixed by #1682

Comments

@veprbl
Copy link

veprbl commented Oct 3, 2021

Here is a full build log
https://gist.github.com/bd9b994ec8e6b891e84d227c13e40b83

After patching

my $pid = open3($writer_discard, $reader_discard, $error_discard, @invocation);

to be something like

my $pid = open3($writer_discard, '>&STDOUT', '>&STDERR', @invocation);

We can see errors like

Error in tempdir() using /data/tmp/nix-build-perl5.34.0-LaTeXML-0.8.6.drv-0/XXXXXXXXXX: Parent directory (/data/tmp/nix-build-perl
5.34.0-LaTeXML-0.8.6.drv-0) is not safe (Sticky bit not set on /data when dir is group|world writable) at /data/tmp/nix-build-perl5.34.0-
LaTeXML-0.8.6.drv-0/LaTeXML-0.8.6/blib/script/../lib/LaTeXML.pm line 196.

And changing ownership of temp directories is not always an option (this is also observed when they are created by our package manager Nix, as a part of a sandbox).

I wonder if it would be acceptable to change the setting to a less restrictive File::Temp::MEDIUM, especially in the light of Perl-Toolchain-Gang/File-Temp#36

@dginev dginev added this to the LaTeXML-0.8.7 milestone Oct 3, 2021
@dginev
Copy link
Collaborator

dginev commented Oct 4, 2021

Curious... Could you confirm that setting it to MEDIUM fixes the issue on your setup @veprbl ?

@veprbl
Copy link
Author

veprbl commented Oct 6, 2021

@dginev Yes, I did test that setting and it works.

@veprbl
Copy link
Author

veprbl commented Oct 8, 2021

@dginev Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants